Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: test/osupdate: New test #682

Closed
wants to merge 1 commit into from
Closed

WIP: test/osupdate: New test #682

wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

This is a new end-to-end test that:

  • Builds a new oscontainer with test content in /usr/share
  • Builds a new release image that derives from the existing
    one (so in theory we're not testing upgrades of other things)
  • Targets the cluster at that release image
  • Waits for the cluster to update
  • Verifies that the test content made it

Not hooked up into CI yet. Tentatively thinking of creating a new context (only run for merges by default) for this, but we could also glom it onto our existing e2e-aws-op.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 29, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2019
@cgwalters cgwalters force-pushed the test-osupdate branch 2 times, most recently from cba8b86 to b39b5fc Compare April 30, 2019 09:22
@cgwalters cgwalters mentioned this pull request Apr 30, 2019
Closed
@cgwalters
Copy link
Member Author

Hm, in this I want to follow a pod's logs while also monitoring its status for completion and propagate the exit code. I could write some custom code for that (I guess oc start-build -F is probably similar) but if anyone knows a convenient kubectl/oc CLI incantation for this that'd be nice!

@cgwalters cgwalters force-pushed the test-osupdate branch 3 times, most recently from ba02f9c to 960861c Compare May 2, 2019 08:20
@cgwalters cgwalters mentioned this pull request May 2, 2019
Merged
@cgwalters cgwalters mentioned this pull request May 8, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2019
@cgwalters cgwalters mentioned this pull request May 21, 2019
Closed
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2019
@cgwalters
Copy link
Member Author

Rebased this to see if the bug in oc adm release new is fixed now.

@cgwalters
Copy link
Member Author 

error: the release could not be reproduced from its inputs

Yeah, this still hits the regression introduced by openshift/origin@15292e0

@cgwalters
Copy link
Member Author

error: the release could not be reproduced from its inputs

So I consulted my "What would ci-operator do?" bracelet and noticed that it was saying --to-image-base and --to-image - and indeed passing both as the same arg seems to fix this. I think it may be something like without that, the other images still try to pull from the original location or something?

Anyways, let's see how this works.

We still need to figure out whether this test is run as part of e2e-aws-op as is, if it's a separate context, or even one we only run manually, etc.

@runcom
Copy link
Member

runcom commented Jul 2, 2019

We still need to figure out whether this test is run as part of e2e-aws-op as is, if it's a separate context, or even one we only run manually, etc.

I'm leaning towards setting up a new job just for this - it's an extra cluster, I know, but still something we might want to offload from e2e-aws-op. Setting up a new job just requrires a new Makefile target and some files in openshift/release also. What do you think?

@runcom
Copy link
Member

runcom commented Jul 2, 2019

looks like a network glitch now

@cgwalters
Copy link
Member Author

/retest

@cgwalters
WIP: test/osupdate: New test
7635b89 
This is a new end-to-end test that:

 - Builds a new oscontainer with test content in /usr/share
 - Builds a new release image that derives from the existing
   one (so in theory we're not testing upgrades of other things)
 - Targets the cluster at that release image
 - Waits for the cluster to update
 - Verifies that the test content made it
@cgwalters cgwalters mentioned this pull request Aug 20, 2019
Closed
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2019
@openshift-ci-robot
Copy link
Contributor

@cgwalters: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@cgwalters: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@cgwalters: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 7635b89 link /test e2e-aws
ci/prow/e2e-aws-op 7635b89 link /test e2e-aws-op
ci/prow/e2e-aws-disruptive 7635b89 link /test e2e-aws-disruptive
ci/prow/e2e-gcp-op 7635b89 link /test e2e-gcp-op
ci/prow/e2e-aws-upgrade 7635b89 link /test e2e-aws-upgrade
ci/prow/e2e-gcp-upgrade 7635b89 link /test e2e-gcp-upgrade
ci/prow/e2e-vsphere 7635b89 link /test e2e-vsphere
ci/prow/build-rpms-from-tar 7635b89 link /test build-rpms-from-tar

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice kikisdeliveryservice added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 3, 2019
@kikisdeliveryservice
Copy link
Contributor

In an effort to clean up the MCO repo, closing old open PRs with no recent activity.

Feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon Awaiting requested review from jlebon

@runcom runcom Awaiting requested review from runcom

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgwalters @openshift-ci-robot @runcom @kikisdeliveryservice