Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.11 Req: Separate types from methods/helpers #371

Closed
afflom opened this issue Mar 17, 2022 · 0 comments · Fixed by #376
Closed

4.11 Req: Separate types from methods/helpers #371

afflom opened this issue Mar 17, 2022 · 0 comments · Fixed by #376
Assignees
@jpower432
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
Release-4.11

Comments

@afflom
Copy link
Contributor

afflom commented Mar 17, 2022

Have a harder split between API types and actual method, helpers, etc.
pkg/config, pkg/metadata, pkg/image should probably all be part of pkg/api/version with
just types_config.go, types_metadata.go and types_image.go containing just the
types and necessary conversions, schemas, etc.
@afflom afflom added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 17, 2022
@afflom afflom added this to the Release-4.11 milestone Mar 17, 2022
@jpower432 jpower432 self-assigned this Mar 18, 2022
jpower432 added a commit to jpower432/bundle that referenced this issue Mar 18, 2022
@jpower432
chore: separates API types from methods and remove bool pointers from…
9c9e9e7 
… API spec

Closes openshift#371
Closes openshift#367

BREAKING CHANGE: removes HeadsOnly keys from ImageSetConfigurationSpec

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
jpower432 added a commit to jpower432/bundle that referenced this issue Mar 18, 2022
@jpower432
chore: separates API types from methods and remove bool pointers from…
9bed5f2 
… API spec

Closes openshift#371
Closes openshift#367

BREAKING CHANGE: removes HeadsOnly keys from ImageSetConfigurationSpec

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
jpower432 added a commit to jpower432/bundle that referenced this issue Mar 18, 2022
@jpower432
chore: separates API types from methods and remove bool pointers from…
4046330 
… API spec

Closes openshift#371
Closes openshift#367

BREAKING CHANGE: removes HeadsOnly keys from ImageSetConfigurationSpec

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 mentioned this issue Mar 18, 2022
Merged
12 tasks
jpower432 added a commit to jpower432/bundle that referenced this issue Mar 21, 2022
@jpower432
chore: separates API types from methods and remove bool pointers from…
e96292b 
… API spec

Closes openshift#371
Closes openshift#367

BREAKING CHANGE: removes HeadsOnly keys from ImageSetConfigurationSpec

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
jpower432 added a commit to jpower432/bundle that referenced this issue Mar 29, 2022
@jpower432
chore: separates API types from methods and remove bool pointers from…
bec4f7e 
… API spec

Closes openshift#371
Closes openshift#367

BREAKING CHANGE: removes HeadsOnly keys from ImageSetConfigurationSpec

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
openshift-merge-robot pushed a commit that referenced this issue Mar 30, 2022
@jpower432
cleanup: API types separation from methods and bool pointer removal f…
4a05424 
…rom API (#376)

* chore: separates API types from methods and remove bool pointers from API spec

Closes #371
Closes #367

BREAKING CHANGE: removes HeadsOnly keys from ImageSetConfigurationSpec

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>

* chore: renames association.go to association_set.go to remove confusion with Association type

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>

* chore: adds comments to public API types in v1alpha2 package

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>

* chore: updated allPackages and allVersions config keys to Full

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpower432 jpower432

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
Release-4.11
Development

Successfully merging a pull request may close this issue.

cleanup: API types separation from methods and bool pointer removal from API jpower432/bundle
2 participants
@afflom @jpower432