Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] New indexes, when published in OCI format, cause errors in the E2E test due to OC failing to handle them properly #404

Closed
jharmison-redhat opened this issue Apr 7, 2022 · 0 comments · Fixed by #405

Comments

@jharmison-redhat
Copy link
Contributor

Version

ca8e594

What happened?

make test-e2e fails, citing an error about signatures. Ex:

error: unable to retrieve source image file://redhatgov/oc-mirror-dev manifest sha256:1bbe238f395663755810ad15b332676fb1d583981d934c7ce34dbff9b13d90c9: missing signature key

What did you expect to happen?

E2E tests to pass

How to reproduce it (as minimally and precisely as possible)?

$ make publish-catalog
$ make test-e2e

Anything else we need to know?

This change is similar to the one that caused invalid OpenShift 4.9.23 release images.

References

https://bugzilla.redhat.com/show_bug.cgi?id=2058421

jharmison-redhat added a commit to jharmison-redhat/oc-mirror that referenced this issue Apr 7, 2022
- This reverts image format to the same as the old publishing script, if
  done on a system with `docker` or `moby` installed.
- fixes openshift#404
openshift-merge-robot pushed a commit that referenced this issue Apr 7, 2022
* Set image format to `docker`

- This reverts image format to the same as the old publishing script, if
  done on a system with `docker` or `moby` installed.
- fixes #404

* Set bundle data to align with old indexes

- Old indexes, being hand crafted, did not have the same data as was
  present in the bundle manifests and metadata. This change aligns the
  bundle data with the old indexes, so they are generated identically.
- fixes #403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant