OCPBUGS-8216: fix: remove an unecessary error message

[aguidirh]

Description

There are some scenarios where an error is expected so it should not print the error message otherwise it will confuse the user.

fixes #576

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Using the command and image set config below:

./bin/oc-mirror --config ocpbugs-8216.yaml docker://localhost:5000 --use-oci-feature --dest-use-http --dest-skip-tls

apiVersion: mirror.openshift.io/v1alpha2
storageConfig:
  local:
    path: /home/aguidi/go/src/github.com/aguidirh/oc-mirror/ocpbugs-8216
mirror:
  operators:
  - catalog: oci:///home/aguidi/dev/catalogs/rhoc4.12
    targetCatalog: mno/redhat-operator-index
    targetTag: v4.12
    packages:
    - name: aws-load-balancer-operator 

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[openshift-ci-robot]

@aguidirh: This pull request references Jira Issue OCPBUGS-8216, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Description

There are some scenarios where an error is expected so it should not print the error message otherwise it will confuse the user.

Fixes #OCPBUGS-8216

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Using the command and image set config below:

./bin/oc-mirror --config ocpbugs-8216.yaml docker://localhost:5000 --use-oci-feature --dest-use-http --dest-skip-tls

apiVersion: mirror.openshift.io/v1alpha2
storageConfig:
 local:
   path: /home/aguidi/go/src/github.com/aguidirh/oc-mirror/ocpbugs-8216
mirror:
 operators:
 - catalog: oci:///home/aguidi/dev/catalogs/rhoc4.12
   targetCatalog: mno/redhat-operator-index
   targetTag: v4.12
   packages:
   - name: aws-load-balancer-operator 

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aguidirh]

/jira refresh

[openshift-ci-robot]

@aguidirh: This pull request references Jira Issue OCPBUGS-8216, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lmzuccarelli]

/lgtm

[openshift-ci]

@aguidirh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@aguidirh: This pull request references Jira Issue OCPBUGS-8216, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

Description

There are some scenarios where an error is expected so it should not print the error message otherwise it will confuse the user.

fixes #576

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Using the command and image set config below:

./bin/oc-mirror --config ocpbugs-8216.yaml docker://localhost:5000 --use-oci-feature --dest-use-http --dest-skip-tls

apiVersion: mirror.openshift.io/v1alpha2
storageConfig:
 local:
   path: /home/aguidi/go/src/github.com/aguidirh/oc-mirror/ocpbugs-8216
mirror:
 operators:
 - catalog: oci:///home/aguidi/dev/catalogs/rhoc4.12
   targetCatalog: mno/redhat-operator-index
   targetTag: v4.12
   packages:
   - name: aws-load-balancer-operator 

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[soltysh]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aguidirh, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@aguidirh: Jira Issue OCPBUGS-8216: All pull requests linked via external trackers have merged:

• openshift/oc-mirror#579

Jira Issue OCPBUGS-8216 has been moved to the MODIFIED state.

In response to this:

Description

There are some scenarios where an error is expected so it should not print the error message otherwise it will confuse the user.

fixes #576

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Using the command and image set config below:

./bin/oc-mirror --config ocpbugs-8216.yaml docker://localhost:5000 --use-oci-feature --dest-use-http --dest-skip-tls

apiVersion: mirror.openshift.io/v1alpha2
storageConfig:
 local:
   path: /home/aguidi/go/src/github.com/aguidirh/oc-mirror/ocpbugs-8216
mirror:
 operators:
 - catalog: oci:///home/aguidi/dev/catalogs/rhoc4.12
   targetCatalog: mno/redhat-operator-index
   targetTag: v4.12
   packages:
   - name: aws-load-balancer-operator 

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aguidirh]

/cherrypick release-4.13

[openshift-cherrypick-robot]

@aguidirh: new pull request created: #581

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.