Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow Atomic Host installs on 4.0 #10277

Merged
merged 3 commits into from
Oct 25, 2018

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Oct 1, 2018

Atomic Host install has been deprecated in 3.11 and cannot be used in master

TODO:

  • Read OS family and disallow Atomic

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 1, 2018
@vrutkovs
Copy link
Member Author

vrutkovs commented Oct 1, 2018

/test gcp-major-upgrade

@vrutkovs
Copy link
Member Author

vrutkovs commented Oct 1, 2018

CSR approval flake during 3.11 setup

/test gcp-major-upgrade

@vrutkovs vrutkovs force-pushed the goodbye-atomic branch 2 times, most recently from ec9c2f0 to 944ea26 Compare October 1, 2018 12:03
@vrutkovs
Copy link
Member Author

vrutkovs commented Oct 1, 2018

/test gcp-major-upgrade

@vrutkovs
Copy link
Member Author

vrutkovs commented Oct 2, 2018

Flakes
/retest

@vrutkovs
Copy link
Member Author

vrutkovs commented Oct 2, 2018

/test install

@vrutkovs vrutkovs changed the title WIP Disallow Atomic Host installs Disallow Atomic Host installs on 4.0 Oct 2, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2018
@vrutkovs
Copy link
Member Author

vrutkovs commented Oct 3, 2018

/test install

2 similar comments
@vrutkovs
Copy link
Member Author

vrutkovs commented Oct 4, 2018

/test install

@vrutkovs
Copy link
Member Author

vrutkovs commented Oct 5, 2018

/test install

@michaelgugino
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 5, 2018
@vrutkovs
Copy link
Member Author

vrutkovs commented Oct 5, 2018

/test e2e-gcp-major-upgrade-master
/test e2e-aws

@vrutkovs
Copy link
Member Author

vrutkovs commented Oct 5, 2018

/retest

@vrutkovs
Copy link
Member Author

vrutkovs commented Oct 8, 2018

/refresh

@vrutkovs
Copy link
Member Author

vrutkovs commented Oct 8, 2018

/retest

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2018
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2018
@vrutkovs
Copy link
Member Author

/refresh
/skip
/retest

@sdodson
Copy link
Member

sdodson commented Oct 24, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino, sdodson, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michaelgugino,sdodson,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 25, 2018

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/install 6b0e156 link /test install
ci/prow/e2e-gcp-major-upgrade-master d373d1b link /test e2e-gcp-major-upgrade-master
ci/prow/e2e-gcp-logging d373d1b link /test e2e-gcp-logging
ci/prow/e2e-gcp-major-upgrade c64ab8f link /test e2e-gcp-major-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Member Author

/test e2e-gcp

@openshift-merge-robot openshift-merge-robot merged commit fbeca2e into openshift:master Oct 25, 2018
register: result
until: result is succeeded

- block:
- name: Pull CLI Image (docker)
- name: Pull CLI Image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shortly after this pull merged, the openshift extended_install job started failing and blocking merges to origin:

https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended_conformance_install/16436/consoleFull#181091684258b6e51eb7608a5981914356


TASK [openshift_cli : Install clients] *****************************************
task path: /usr/share/ansible/openshift-ansible/roles/openshift_cli/tasks/main.yml:2
ok: [localhost] => {
    "attempts": 1, 
    "changed": false, 
    "generated_timestamp": "2018-10-25 13:23:31.669277", 
    "msg": "", 
    "rc": 0, 
    "results": [
        "origin-clients-4.0.0-0.alpha.0.409.853d900.x86_64 providing origin-clients-4.0.0-0.alpha.0.409.853d900 is already installed"
    ]
}

TASK [openshift_cli : Pull CLI Image] ******************************************
task path: /usr/share/ansible/openshift-ansible/roles/openshift_cli/tasks/main.yml:10
fatal: [localhost]: FAILED! => {
    "changed": false, 
    "generated_timestamp": "2018-10-25 13:23:32.405818", 
    "msg": "Error pulling docker.io/openshift/origin-node - code: None message: manifest for docker.io/openshift/origin-node:853d900 not found"
}

PLAY RECAP *********************************************************************
 [WARNING]: Could not create retry file '/usr/share/ansible/openshift-
ansible/playbooks/deploy_cluster.retry'.         [Errno 13] Permission denied:
u'/usr/share/ansible/openshift-ansible/playbooks/deploy_cluster.retry'
localhost                  : ok=228  changed=93   unreachable=0    failed=1   

That seems like too much of a coincidence. Did the default change so that this block was getting called?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we've already removed that job, so we can simply turn it off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants