unescape uri in HandleAuthorizeRequest #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes you're right, as urls get passed in various ways (url, post variables), it is a good thing to do. |
RangelReale
added a commit
that referenced
this pull request
Feb 4, 2014
unescape uri in HandleAuthorizeRequest
|
Cool, thanks! Great job on osin library, btw :) Saved me tons of time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to unescape redirect uri in handleCodeRequest() and handleTokenRequest().
I think it's safe to assume that people will be storing unescaped client redirect uri (baseUri) in a database, so we need to be consistent and always compare unescaped both baseUri & redirectUri - otherwise, if we get an escaped redirect uri from a login page, ValidateUri() will fail.
Please let me know what you think.