Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refined the topology-specific config procedure #511

Conversation

klgill
Copy link
Contributor

@klgill klgill commented Jun 27, 2024

@matbu Can you please review my edits to the "Retrieving topology-specific service configuration" procedure and address the questions I've asked on this PR?
Thank you.

Comment on lines 75 to 77
[IMPORTANT]
After the source control plane services are shut down, if any of the exported
values are lost, the values cannot be evaluated again. To avoid data loss, preserve the exported values in an environment file before shutting down the control plane services.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matbu I have the following questions regarding this note:

  1. What is meant by “the values cannot be evaluated again”?
  2. Is this note referring to when customers stop their RHOSP services in section 3.5?https://docs.redhat.com/en/documentation/red_hat_openstack_services_on_openshift/18.0-beta/html-single/adopting_a_red_hat_openstack_platform_17.1_deployment/index#stopping-openstack-services_migrating-databases
  3. Does this note apply more to step 6, where we're telling customers to store the variables for future use?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klgill I think @bogdando is the autor of this part, maybe @bogdando can confirm this updates ?

Copy link
Contributor

@bogdando bogdando Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the values cannot be evaluated again - if we re-run the commands, they will fail as there are no longer control plane services running on the source cloud to get the data from (and those cannot be started back).

@klgill klgill requested a review from matbu June 27, 2024 17:35
@klgill klgill force-pushed the Docs-Refine-Retrieving-topology-specific-service-config branch from a7109c4 to 615cd62 Compare July 8, 2024 16:57
@@ -4,7 +4,7 @@

= Migrating databases to the control plane

To begin creating the control plane, enable backend services and import the databases from your original {rhos_prev_long} {rhos_prev_ver} deployment.
To begin creating the control plane, enable back-end services and import the databases from your original {rhos_prev_long} {rhos_prev_ver} deployment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this assembly/user story just the beginning (To begin creating the control plane) of the creation of the control plane? I'd like to see a complete picture (super procedure) somewhere of the list of user stories in order, that you must complete.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoanneOFlynn2018 I have a plan to write an adoption workflow checklist, which would detail the preparation, main adoption procedure, and post-adoption tasks. Is that what you're referring to?

values in an environment file should protect you from such a situation.
[IMPORTANT]
After the {OpenStackShort} control plane services are shut down, if any of the exported
values are lost, re-running the command fails because the values cannot be evaluated again. To avoid data loss, preserve the exported values in an environment file before shutting down the control plane services.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the user understand "the values cannot be evaluated again"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have elaborated the meaning in the comment above: "the values cannot be evaluated again" - if we re-run the commands, they will fail as there are no longer control plane services running on the source cloud to get the data from (and those cannot be started back).

Feel free to rephrase, with preserving the original intent

Copy link
Contributor Author

@klgill klgill Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bogdando . When you say "re-run the commands", do you mean the "export" commands specifically, or any commands in this procedure?

Copy link
Contributor

@bogdando bogdando Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the commands in this chapter would work after its related services stopped on the source cloud

@klgill klgill force-pushed the Docs-Refine-Retrieving-topology-specific-service-config branch from 7c21d20 to 64b8839 Compare July 9, 2024 13:49
@klgill klgill merged commit 3890c95 into openstack-k8s-operators:main Jul 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants