Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refined networking service procedure #512

Merged

Conversation

klgill
Copy link
Contributor

@klgill klgill commented Jun 28, 2024

The {networking_service} adoption is complete if you see the following results:

* The `NeutronAPI` service is running.
* The {identity_service_first_ref} endpoints are updated, and the same back end of the source cloud is available.

This guide also assumes that:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slawqo Can you help me understand how this part is relevant to the procedure?

Also, what is meant by “one side” and “other side”? Do you mean "source environment (RHOSP)" and "target environment (the OpenShift cluster)"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what exactly You are asking for. This says about how to start adoption of the networking service (patch existing CR where neutron service was disabled to enable it) and how to validate that this adoption was finished (check that NeutronAPI is running and networking endpoints in the keystone db points to the new neutron service in the OpenShift cluster, and not the one in the OSP 17.1)

Where do You see "one side" and "other side" there? I don't see it so it is hard for me to tell what it means.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slawqo I apologize for the confusion. My comment applies to the following text:
"This guide also assumes that:
. A {OpenStackPreviousInstaller} environment (the source Cloud) is running on one side;
. A SNO / CodeReadyContainers is running on the other side."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, so the 'one side' is actually old, tripleo/Director based deployment and 'the other side' is in this context is Openshift cluster (it can be CRC in e.g. u/s ci)

@klgill
Copy link
Contributor Author

klgill commented Jun 28, 2024

@slawqo The following comment is still in the file. Does info on SR-IOV adoption need to be added?
//NOTE: this page should be expanded to include information on SR-IOV adoption.

@klgill klgill requested a review from slawqo June 28, 2024 18:09

.Procedure
//The following link takes me to a 404. Do we need this text? I think we should start the procedure at "Patch OpenStackControlPlane..."
ifeval::["{build}" != "downstream"]
As already done for https://github.com/openstack-k8s-operators/data-plane-adoption/blob/main/keystone_adoption.md[Keystone], the Neutron Adoption follows the same pattern.
endif::[]

* Patch `OpenStackControlPlane` to deploy {networking_service}:
* Patch the `OpenStackControlPlane` CR to deploy the {networking_service}:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slawqo Which files is being updated in this step? Is it the openstack_control_plane.yaml file, which defines the OpenStackControlPlane CR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically what is updated in this step is the OpenStackControlPlane CR which is already in the OpenShift. You can do it in many different ways, like e.g.:

  1. updating openstack_control_plane.yaml file and then use oc apply -f command to apply that file to the OCP,
  2. using oc edit openstackcontrolplane command and then update it "live" in the text editor,
  3. using oc patch command to patch existing CR and change this setting - this method is showed below

@slawqo
Copy link
Contributor

slawqo commented Jul 1, 2024

@slawqo The following comment is still in the file. Does info on SR-IOV adoption need to be added? //NOTE: this page should be expanded to include information on SR-IOV adoption.

I think this can be removed simply as SR-IOV adoption is already described in the https://github.com/openstack-k8s-operators/data-plane-adoption/blob/main/docs_user/modules/proc_adopting-compute-services-to-the-data-plane.adoc

@klgill klgill force-pushed the Docs-Refine-Networking-Service branch from ad023a6 to 8c1fa9f Compare July 3, 2024 14:08
@klgill klgill merged commit 578d41f into openstack-k8s-operators:main Jul 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants