-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refined object storage procedure #513
refined object storage procedure #513
Conversation
docs_user/modules/proc_adopting-the-object-storage-service.adoc
Outdated
Show resolved
Hide resolved
docs_user/modules/proc_adopting-the-object-storage-service.adoc
Outdated
Show resolved
Hide resolved
@@ -49,11 +48,11 @@ binaryData: | |||
EOF | |||
---- | |||
|
|||
. Patch `OpenStackControlPlane` to deploy the {object_storage}: | |||
. Patch the `OpenStackControlPlane` custom resource to deploy the {object_storage}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cschwede Which file is being updated in this step? Is it the openstack_control_plane.yaml file, which defines the OpenStackControlPlane CR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly that file. One can either patch an already existing CR (like in this example case) or patch the file before creating the CR.
docs_user/modules/proc_adopting-the-object-storage-service.adoc
Outdated
Show resolved
Hide resolved
c065c97
to
da12187
Compare
|
||
This section only applies if you are using OpenStack Swift as {object_storage_first_ref}. If you are using the Object Storage API of Ceph RGW this section can be skipped. | ||
If you are using OpenStack Swift as an {object_storage}, adopt the {object_storage} to the {rhos_long} environment. If you are using the Object Storage API of the Ceph Object Gateway (RGW), skip this procedure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could maybe put "Optional" at the start of this sentence. Is the point of this line that you have to adopt the {object_storage} to the {rhos_long} environment if you use OpenStack Swift as an {object_storage}? If so, maybe: "If you use OpenStack Swift as an {object_storage}, ensure that you adopt the {object_storage} to the {rhos_long} environment."
Skip what procedure? The "adopt the {object_storage} to the {rhos_long} environment" or what comes next? The original draft makes it look like it's what follows, whereas the rewrite could be interpreted as the step you just mentioned in the previous line. Could clarify with "skip the following procedure" or "you do not need to adopt the {object_storage} to the {rhos_long} environment." or whatever the case may be.
Should you say the OpenStack Object Store Service (Swift) or something like that?
Also maybe OpenStack could be made into a variable so it is OpenStack upstream and RHOSP downstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means that you only have to complete the following procedure if you are using Swift as an object storage service (which is probably similar to what you said). If you are using Swift with RGW, you do not have to complete the following procedure.
https://issues.redhat.com/browse/RHOSPDOC-1655