Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for valid service override endpoint type on create and update #414

Merged

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented May 7, 2024

@openshift-ci openshift-ci bot requested review from dprince and lewisdenny May 7, 2024 14:12
@openshift-ci openshift-ci bot added the approved label May 7, 2024
@stuggi
Copy link
Contributor Author

stuggi commented May 7, 2024

/hold until after beta freeze

@stuggi stuggi requested review from abays and removed request for lewisdenny May 7, 2024 14:14
stuggi added a commit to stuggi/openstack-operator that referenced this pull request May 7, 2024
@stuggi stuggi force-pushed the endpoint_webhook branch 3 times, most recently from b071177 to 7654e4e Compare May 8, 2024 08:44
stuggi added a commit to stuggi/openstack-operator that referenced this pull request May 14, 2024
Copy link
Contributor

@xek xek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label May 23, 2024
Copy link
Contributor

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi, xek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 53aebcc into openstack-k8s-operators:main May 23, 2024
6 checks passed
stuggi added a commit to stuggi/openstack-operator that referenced this pull request May 23, 2024
stuggi added a commit to stuggi/openstack-operator that referenced this pull request May 23, 2024
stuggi added a commit to stuggi/openstack-operator that referenced this pull request May 24, 2024
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Jun 3, 2024
stuggi added a commit to stuggi/openstack-operator that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants