Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expired config options #325

Conversation

nlsvgtr
Copy link
Contributor

@nlsvgtr nlsvgtr commented Feb 25, 2022

Description

Remove global option mapImageFlag which was not used anywhere

Type of change

Code improvement

Documentation

N/A

Tests

Only locally

Copy link
Contributor

@rudivanhierden rudivanhierden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idea.locationMapImage is only used in the begroot widget ( in ideas-list.html, line 98 ), which has been deprecated since 2 years, so IMO this PR can be merged and we can remove the begroot widget at a later stage.

@nlsvgtr nlsvgtr merged commit 24d97e0 into openstad:development Feb 28, 2022
@nlsvgtr nlsvgtr deleted the codeimprovement/remove-expired-config-options branch February 28, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants