Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fields.js bugfix 'no sentiment' #357

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

LorenzoJokhan
Copy link
Contributor

@LorenzoJokhan LorenzoJokhan commented Sep 16, 2022

Description

Made it possible for arguments with 'no sentiment' to be added to the databases
REQUIRES openstad/openstad-api#244 to work, if this one is not available then the API will reject the value send by this fix.

Issue reference

Fixes # (issue)
Belongs to bug https://trello.com/c/URra6zQt

Type of change

bugfix (wrong branchname, by accident)

Tests

  • Login as admin on a site of your choosing.
  • Go to 'plannen'
  • Create a plan to use if no plans are available
  • go to the ' edit arguments' section and change one of the boxes to use to the 'no sentiment' option.

Branch

devel

Added no sentiment option for the field, so that it will be send correctly to the api. Belongs to bug https://trello.com/c/URra6zQt
@LorenzoJokhan LorenzoJokhan merged commit 2830567 into development Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants