Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/edit succesfull voting on budgeting widget #383

Merged

Conversation

LorenzoJokhan
Copy link
Contributor

Description

Please include

  • a summary of the changes
  • relevant motivation and context
  • a list of any dependencies that are required for this change

Issue reference

Fixes # (issue)

Type of change

Is it a new feature, bug fix, code improvement, etc.
If it is a breaking change what needs to be done to fix that

Documentation

Is the documentation updated, maybe a link

Tests

(How) has the change been tested

Branch

If the branch to merge to is not development

Copy link
Contributor

@rudivanhierden rudivanhierden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

succesfull is de verkeerde spelling, maar ik zie dat het voor step_3_succesfull_auth ook al zo stond. Zou wat mij betreft mooi zijn om dat voor beiden te corrigeren naar successful, wat vindt jij?

Verder inhoudelijk prima!

Copy link
Contributor

@rudivanhierden rudivanhierden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Thanks!

@LorenzoJokhan
Copy link
Contributor Author

succesfull is de verkeerde spelling, maar ik zie dat het voor step_3_succesfull_auth ook al zo stond. Zou wat mij betreft mooi zijn om dat voor beiden te corrigeren naar successful, wat vindt jij?

Verder inhoudelijk prima!

Heb voor de netheid de spelling aangepast voor de voting_title en een nieuwe PR geopend met de spelling correctie van successful_auth: https://github.com/openstad/openstad-frontend/pull/384/files

@LorenzoJokhan LorenzoJokhan merged commit db4147b into development Feb 13, 2023
@LorenzoJokhan LorenzoJokhan deleted the feature/edit-succesfull-voting-on-budgeting-widget branch February 13, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants