Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpaceFillingMinDist documentation #1203

Open
mathieu-couplet opened this issue Aug 21, 2019 · 1 comment
Open

SpaceFillingMinDist documentation #1203

mathieu-couplet opened this issue Aug 21, 2019 · 1 comment
Labels

Comments

@mathieu-couplet
Copy link
Contributor

Hello.

Apparently, this class performs a scaling (to get numbers between 0 and 1) along each marginal before computing the minimum (euclidean) distance: this scaling is not documented. This may lead to a wrong use of the class.

The fact that the computed distance is the euclidean one should be indicated.

Thanks,
regards,
Mathieu

@jschueller jschueller added the doc label Aug 30, 2019
@mbaudin47
Copy link
Collaborator

@mathieu-couplet : it seems to me that the code uses the normalize method of the sample:

const Sample normalizedSample(normalize(sample));

This method does not seem to be available at the Python level, but is implemented here:
Sample SpaceFillingImplementation::normalize(const Sample & sample) const

The code is clear: only the min and the max of the sample are used to normalize it (not the distribution as I thought).

josephmure added a commit to josephmure/openturns that referenced this issue Mar 8, 2021
josephmure added a commit to josephmure/openturns that referenced this issue Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants