Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AZP: do not include libjucx into release packages. #6440

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

petro-rudenko
Copy link
Member

What

JUCX is used solely from maven dependency.

Why ?

To not mess up classpath with libjucx.so.

cc @abellina

Copy link
Contributor

@yosefe yosefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it needed for v1.10?

@petro-rudenko
Copy link
Member Author

@yosefe would be nice to have, to prevent problems in the future. When people will install 1.10 and have libjucx.so for 1.10 in /usr/lib and use jucx-1.11 from maven #6441

@yosefe
Copy link
Contributor

yosefe commented Mar 3, 2021

@yosefe would be nice to have, to prevent problems in the future. When people will install 1.10 and have libjucx.so for 1.10 in /usr/lib and use jucx-1.11 from maven #6441

I think it's more than "nice to have", given the explanation..

@petro-rudenko
Copy link
Member Author

@abellina
Copy link

abellina commented Mar 3, 2021

I think it's more than "nice to have", given the explanation..

It would be good to know if libjucx.so in the packaging, vs the one bundled with jucx JAR in maven central, are built with different options. nm shows some differences, and if we force load using LD_PRELOAD we end up crashing, even if we built using the jucx-1.9.0 jar that is published.

It seems that if the only reason for libjucx.so is for the JAR to use it (and now it bundles it), then removing it from the /usr/lib removes extra files and potential issues.

I should mention that I can't get this to happen unless I force load libjucx.so using preload. I've asked the reported to try LD_DEBUG to prove he gets the libjucx.so from /usr/lib. @rongou fyi.

@yosefe yosefe merged commit 3742486 into openucx:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants