Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[select] The actual JS API surface and capabilities are not described anywhere #705

Closed
domenic opened this issue Mar 31, 2023 · 2 comments · Fixed by #709
Closed

[select] The actual JS API surface and capabilities are not described anywhere #705

domenic opened this issue Mar 31, 2023 · 2 comments · Fixed by #709
Assignees
@josepharhar
Labels
select These are issues that relate to the select component

Comments

@domenic
Copy link
Contributor

domenic commented Mar 31, 2023

E.g. does this support normal form control semantics? Is it even form-associated? What parts of the JS API carry over?

I vaguely remember @josepharhar reassuring me in some thread that this was implemented, but I can't find it in this repository. In the meantime, the explainer has no such information.
josepharhar added a commit to josepharhar/open-ui that referenced this issue Mar 31, 2023
@josepharhar
Add form semantics section
2f71733 
This addresses openui#705
@josepharhar
Copy link
Collaborator

Thanks for bringing this up, I will add form semantics to the explainer.
I have drafted the text for it here: 2f71733
I will open a PR to add it to the explainer once this PR has been merged first: #707

@josepharhar josepharhar self-assigned this Mar 31, 2023
@josepharhar josepharhar added the select These are issues that relate to the select component label Mar 31, 2023
josepharhar added a commit to josepharhar/open-ui that referenced this issue Apr 6, 2023
@josepharhar
Add form semantics section
120d0cb 
This addresses openui#705
@josepharhar josepharhar mentioned this issue Apr 6, 2023
Merged
@josepharhar
Copy link
Collaborator

I opened a PR: #709

josepharhar added a commit that referenced this issue Jun 22, 2023
@josepharhar
Add form semantics section (#709)
7535035 
This addresses #705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josepharhar josepharhar

Labels
select These are issues that relate to the select component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add form semantics section josepharhar/open-ui
2 participants
@domenic @josepharhar