Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch proposal #785

Merged
merged 38 commits into from
Feb 29, 2024
Merged

Switch proposal #785

merged 38 commits into from
Feb 29, 2024

Commits on Jul 15, 2023

  1. chore: initialize switch explainer

    @gfellerph
    gfellerph committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    e7e84a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Update switch explainer

    @gfellerph
    gfellerph committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    c59f4cd View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Update switch.explainer.mdx

    @gfellerph
    gfellerph committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    f7b3ac7 View commit details
    Browse the repository at this point in the history

  2. Update non-goals

    @gfellerph
    gfellerph committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    1e5e423 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Update switch.explainer.mdx

    @gfellerph
    gfellerph committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    b4f8321 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. added anatomy images and updated formatting

    @gfellerph
    gfellerph committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    3b64060 View commit details
    Browse the repository at this point in the history

  2. fix: improve question rendering 

    Improves the rendering of questions in editors drafts. A little more padding, no break between question and number, mobile styling, margin between elements.
    @gfellerph
    gfellerph committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2a02b85 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'openui:main' into switch-proposal

    @gfellerph
    gfellerph authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    fa2ec2f View commit details
    Browse the repository at this point in the history

  4. Update switch.explainer.mdx

    @gfellerph
    gfellerph committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    41794e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Incorporate feedback from @scottaohara about accessibility 

    openui#785 (comment)
openui#785 (comment)
openui#785 (comment)
openui#785 (comment)
    @gfellerph
    gfellerph committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    b65b673 View commit details
    Browse the repository at this point in the history

  2. Added link to parallel efforts

    @gfellerph
    gfellerph committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    581a9f2 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Update accessibility section 

    Remove sentence about AT exposure on @scottaohara's recommendation.
    @gfellerph
    gfellerph committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    312efb4 View commit details
    Browse the repository at this point in the history

  2. Updated DOM structure proposal to match elements approach 

    Namings need to be discussed.
    @gfellerph
    gfellerph committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    1fbf0cb View commit details
    Browse the repository at this point in the history

  3. Update research format for immediate action research

    @gfellerph
    gfellerph committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    bb3c0c3 View commit details
    Browse the repository at this point in the history

  4. Added link to research page

    @gfellerph
    gfellerph committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    75baa9a View commit details
    Browse the repository at this point in the history

  5. Update DOM structure to reuse trackside element

    @gfellerph
    gfellerph committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e9379c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. fix image urls

    @gfellerph
    gfellerph committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    b8d57b2 View commit details
    Browse the repository at this point in the history

  2. add screen recordings of prior art

    @gfellerph
    gfellerph committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    3446134 View commit details
    Browse the repository at this point in the history

  3. comment instructions

    @gfellerph
    gfellerph committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    413b5d4 View commit details
    Browse the repository at this point in the history

  4. update anatomy and parts section

    @gfellerph
    gfellerph committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    d9004d3 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/main' into switch-proposal

    @gfellerph
    gfellerph committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    d30f0a9 View commit details
    Browse the repository at this point in the history

  6. clarified sample size for analysis

    @gfellerph
    gfellerph committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    33abbad View commit details
    Browse the repository at this point in the history

  7. the antonym of toggled is untoggled 

    openui#785 (comment)
    @gfellerph
    gfellerph committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    135a422 View commit details
    Browse the repository at this point in the history

  8. added backlink to issue for reference

    @gfellerph
    gfellerph committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    bfd5f6f View commit details
    Browse the repository at this point in the history

  9. typo

    @gfellerph
    gfellerph committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    e1f0e22 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Merge branch 'main' into switch-proposal

    @gfellerph
    gfellerph committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    babfd08 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. updated the explainer 

    - Renamed from editor's draft to explainer
- Changed the menu section to active proposals
- Added a section where the switch attribute and the element are being compared
- Added explanatory images for edge cases
- Added two small paragraphs in the design section about user interaction and styleability
    @gfellerph
    gfellerph committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    5710d87 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Update site/src/pages/components/switch.explainer.mdx 

    Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
    @gfellerph @scottaohara
    gfellerph and scottaohara authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    8a6c136 View commit details
    Browse the repository at this point in the history

  2. Update site/src/pages/components/switch.explainer.mdx 

    Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
    @gfellerph @scottaohara
    gfellerph and scottaohara authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    cb8b459 View commit details
    Browse the repository at this point in the history

  3. Update site/src/pages/components/switch.explainer.mdx 

    Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
    @gfellerph @keithamus
    gfellerph and keithamus authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    a7b6810 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. save hotlinked images locally and add attributions

    @gfellerph
    gfellerph committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    2185e48 View commit details
    Browse the repository at this point in the history

  2. remove the proposal for type="submit" 

    As discussed on the initial pull request (openui#785 (comment)), treating the switch as a button with submission capabilities has potential accessibility issues as mentioned by @scottaohara.
    @gfellerph
    gfellerph committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    b433da9 View commit details
    Browse the repository at this point in the history

  3. clarify text

    @gfellerph
    gfellerph committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    031675d View commit details
    Browse the repository at this point in the history

  4. specify interaction patterns

    @gfellerph
    gfellerph committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    1bcbf0b View commit details
    Browse the repository at this point in the history

  5. clarify checked state

    @gfellerph
    gfellerph committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    0b5462a View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. added allowed content resolution

    @gfellerph
    gfellerph committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    04b8b47 View commit details
    Browse the repository at this point in the history

  2. add info about safari implementation of input switch

    @gfellerph
    gfellerph committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    c9095fb View commit details
    Browse the repository at this point in the history

  3. update from comments on the PR

    @gfellerph
    gfellerph committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    b92a94a View commit details
    Browse the repository at this point in the history