[Torch] Fix classification sample metric dumps not in main process #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniil-lyakhov
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2146 +/- ##
===========================================
+ Coverage 36.23% 36.24% +0.01%
===========================================
Files 477 477
Lines 42544 42570 +26
===========================================
+ Hits 15414 15428 +14
- Misses 27130 27142 +12 |
daniil-lyakhov
force-pushed
the
dl/fix_torch_training_test
branch
from
aa6a5ba
to
9dd78cf
Compare
vshampor
requested changes
Sep 19, 2023
Comment on lines
731
to
732
| if is_main_process(): | ||
| if log_validation_info: |
There was a problem hiding this comment.
Keep the original version with and to have less levels of indent
vshampor
approved these changes
Sep 19, 2023
|
Build is successful, it's safe to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In torch classification sample:
write_metricsandmlflowaccuracy logging is called only in main processReason for changes
Torch test_compression_training (build 106) failed due to metric collected by
write_metricsand metric saved in checkpoint with key "best_acc1" were differentTests
Torch test_compression_training build
109111