Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a provisional section on pytest code style w.r.t. fixtures #2220

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

vshampor
Copy link
Contributor

Changes

As stated in the title

Reason for changes

This doesn't seem obvious to some developers, so will state this in the style guide.

Related tickets

N/A

Tests

N/A

@vshampor vshampor requested a review from a team as a code owner October 25, 2023 15:31
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 25, 2023
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/styleguide/PyGuide.md Outdated Show resolved Hide resolved
docs/styleguide/PyGuide.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2220 (f943269) into develop (da16069) will increase coverage by 54.30%.
Report is 25 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2220       +/-   ##
============================================
+ Coverage    36.40%   90.71%   +54.30%     
============================================
  Files          486      485        -1     
  Lines        43469    43641      +172     
============================================
+ Hits         15827    39589    +23762     
+ Misses       27642     4052    -23590     
Flag Coverage Δ
COMMON 15.74% <ø> (?)
ONNX 33.79% <ø> (?)
OPENVINO 38.56% <ø> (?)
TENSORFLOW 30.01% <ø> (?)
TORCH 62.68% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 354 files with indirect coverage changes

docs/styleguide/PyGuide.md Outdated Show resolved Hide resolved
docs/styleguide/PyGuide.md Outdated Show resolved Hide resolved
@vshampor vshampor merged commit b2511f1 into openvinotoolkit:develop Nov 10, 2023
9 checks passed
@vshampor vshampor deleted the pytest_code_style branch January 9, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants