Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model-hub tests to check wrap_model #2275

Merged

Conversation

AlexanderDokuchaev
Copy link
Collaborator

Changes

Related tickets

124852

Tests

tests/torch/models_hub_test

@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner November 16, 2023 14:29
@github-actions github-actions bot added the NNCF PT Pull requests that updates NNCF PyTorch label Nov 16, 2023
@AlexanderDokuchaev
Copy link
Collaborator Author

Github action can be run before merge to develop.
Checked on default host (with low limit of RAM), test runs but killed by OOM.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #2275 (3596af2) into develop (2e48ffb) will increase coverage by 0.01%.
Report is 8 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2275      +/-   ##
===========================================
+ Coverage    90.75%   90.76%   +0.01%     
===========================================
  Files          485      486       +1     
  Lines        43744    43769      +25     
===========================================
+ Hits         39700    39729      +29     
+ Misses        4044     4040       -4     
Flag Coverage Δ
COMMON 15.87% <ø> (+0.05%) ⬆️
ONNX 33.83% <ø> (-0.02%) ⬇️
OPENVINO 38.69% <ø> (+0.03%) ⬆️
TENSORFLOW 30.03% <ø> (-0.01%) ⬇️
TORCH 62.67% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/torch/models_hub_test/common.py Outdated Show resolved Hide resolved
tests/torch/models_hub_test/test_hf_transformers.py Outdated Show resolved Hide resolved
tests/torch/models_hub_test/__init__.py Show resolved Hide resolved
tests/torch/models_hub_test/common.py Show resolved Hide resolved
@AlexanderDokuchaev
Copy link
Collaborator Author

@alexsu52 alexsu52 dismissed vshampor’s stale review November 29, 2023 05:27

All comments were reviewed

@alexsu52 alexsu52 merged commit 3706639 into openvinotoolkit:develop Nov 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants