OVWeightUpdateCommand copies a constant #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF OpenVINO
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2277 +/- ##
========================================
Coverage 90.76% 90.76%
========================================
Files 486 486
Lines 43763 43764 +1
========================================
+ Hits 39722 39723 +1
Misses 4041 4041
Flags with carried forward coverage won't be shown. Click here to find out more.
|
andrey-churkin
force-pushed
the
ac/const
branch
from
f107965
to
d401c3d
Compare
alexsu52
reviewed
Nov 21, 2023
andrey-churkin
force-pushed
the
ac/const
branch
from
57d79fa
to
6c79b84
Compare
I have used the Quantization Wall Time Before (NNCF develop): 401.24 sec |
andrey-churkin
force-pushed
the
ac/const
branch
from
6c79b84
to
c97f231
Compare
KodiaqQ
reviewed
Nov 22, 2023
KodiaqQ
requested changes
Nov 22, 2023
andrey-churkin
force-pushed
the
ac/const
branch
2 times, most recently
from
62166b0
to
7a1914a
Compare
KodiaqQ
reviewed
Nov 22, 2023
KodiaqQ
approved these changes
Nov 22, 2023
I've filled the ticket. Ref: 125777 |
andrey-churkin
force-pushed
the
ac/const
branch
from
262b593
to
b55d4f5
Compare
Co-authored-by: Nikita Malinin <nikita.malinin@intel.com>
andrey-churkin
commented
Nov 23, 2023
| const_value = np.reshape(const_value, const_shape).astype(const_dtype) | ||
|
|
||
| # TODO(andrey-churkin): Replace on opset13.constant() in a future release | ||
| new_const_node = ov.op.Constant(const_value, shared_memory=True) |
There was a problem hiding this comment.
I'm just adding a note that using ov.op.Constant is not consistent with our current approach of using opset from Python API.
alexsu52
approved these changes
Nov 23, 2023
KodiaqQ
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
get_const_value()method. This method was initially implemented as a workaround in PR 1654, but it is no longer needed and can be replaced withconst_op.data.const_op.get_data()withconst_op.databecause theconst_op.get_data()legacy method and.dataproperty should be used.shared_memoryparameter toTrueduring constant creation to avoid copying the constant.Reason for changes
const_od.get_data()method copies constant.opset.constant(...).Related tickets
Ref: 122922
Tests
N/A