Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in md files #2543

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

AlexanderDokuchaev
Copy link
Collaborator

Changes

  • Add action to check broken links.
  • Fix broken links

Reason for changes

Existed broken links and no any test to check it.

Related tickets

131357

@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner March 4, 2024 06:24
@github-actions github-actions bot added documentation Improvements or additions to documentation NNCF TF Pull requests that updates NNCF TensorFlow experimental NNCF ONNX Pull requests that updates NNCF ONNX labels Mar 4, 2024
@AlexanderDokuchaev
Copy link
Collaborator Author

Example of output on develop:

File: CONTRIBUTING.md:27 • Link: ./tests/data • Error: Path does not exist
File: README.md:44 • Link: ./docs/compression_algorithms/Quantization.md#mixed_precision_quantization • Error: Not found fragment
File: docs/Usage.md:306 • Link: ./accuracy_aware_model_training/AdaptiveCompressionTraining.md • Error: Path does not exist
File: docs/Usage.md:317 • Link: ./accuracy_aware_model_training/AdaptiveCompressionTraining.md • Error: Path does not exist
File: docs/Usage.md:381 • Link: ./accuracy_aware_model_training/AdaptiveCompressionTraining.md • Error: Path does not exist
File: docs/Usage.md:383 • Link: ../../examples/torch/classification/main.py • Error: Path is not within git repository
File: docs/Usage.md:383 • Link: ../../examples/torch/classification/configs/pruning/resnet18_cifar10_accuracy_aware.json • Error: Path is not within git repository
File: examples/tensorflow/object_detection/README.md:9 • Link: https://github.com/tensorflow/models/tree/master/official/vision/detection • Error: 404: Not Found
File: examples/tensorflow/segmentation/README.md:9 • Link: https://github.com/tensorflow/models/tree/master/official/vision/detection • Error: 404: Not Found
File: nncf/experimental/torch/sparsity/movement/MovementSparsity.md:81 • Link: (https://arxiv.org/pdf/2005.07683.pdf • Error: Path does not exist
File: nncf/experimental/torch/sparsity/movement/MovementSparsity.md:82 • Link: (https://arxiv.org/pdf/2109.04838.pdf • Error: Path does not exist
File: tests/onnx/README.md:25 • Link: benchmarking/README.md#prepare-models • Error: Not found fragment
File: tests/onnx/README.md:26 • Link: benchmarking/README.md#prepare-models • Error: Not found fragment
File: tests/onnx/benchmarking/README.md:25 • Link: https://github.com/onnx/models/blob/main/vision/classification/alexnet/model/bvlcalexnet-12.onnx • Error: 404: Not Found
...

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.60%. Comparing base (c5b3df8) to head (0eed480).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2543      +/-   ##
===========================================
- Coverage    90.92%   84.60%   -6.32%     
===========================================
  Files          498      498              
  Lines        45550    45553       +3     
===========================================
- Hits         41415    38542    -2873     
- Misses        4135     7011    +2876     

see 61 files with indirect coverage changes

Flag Coverage Δ
COMMON 42.73% <ø> (+<0.01%) ⬆️
ONNX 34.77% <ø> (-0.01%) ⬇️
OPENVINO ∅ <ø> (∅)
TENSORFLOW 29.59% <ø> (-0.06%) ⬇️
TORCH 66.01% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.10% <ø> (-0.66%) ⬇️
torch 93.43% <ø> (+<0.01%) ⬆️
tensorflow 93.72% <ø> (-0.24%) ⬇️
onnx 93.05% <ø> (ø)
openvino 25.58% <ø> (-68.49%) ⬇️
ptq 67.31% <ø> (-20.43%) ⬇️

tests/onnx/README.md Outdated Show resolved Hide resolved
Co-authored-by: Lyalyushkin Nikolay <nikolay.lyalyushkin@intel.com>
@KodiaqQ KodiaqQ merged commit 481ce9d into openvinotoolkit:develop Mar 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation experimental NNCF ONNX Pull requests that updates NNCF ONNX NNCF TF Pull requests that updates NNCF TensorFlow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants