Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce an ignored subgraph #2548

Merged

Conversation

andrey-churkin
Copy link
Contributor

Changes

Introduce an ability to define subgraph in ignored scope

Reason for changes

The models get more complicated in terms of structure. Noticed many times, that it's impossible to exclude some parts of the model from quantization using the existing ignore scope functionality.

Related tickets

Ref: 100999

Tests

tests/common/test_ignored_scope.py

@andrey-churkin andrey-churkin requested a review from a team as a code owner March 5, 2024 15:18
@github-actions github-actions bot added the NNCF Common Pull request that updates NNCF Common label Mar 5, 2024
@openvino-nncf-ci openvino-nncf-ci added the API Public API-impacting changes label Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 45.83333% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 84.58%. Comparing base (760d1d5) to head (35bbe22).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2548      +/-   ##
===========================================
- Coverage    90.92%   84.58%   -6.34%     
===========================================
  Files          498      498              
  Lines        45553    45576      +23     
===========================================
- Hits         41418    38552    -2866     
- Misses        4135     7024    +2889     
Files Coverage Δ
nncf/__init__.py 98.07% <100.00%> (+0.03%) ⬆️
nncf/scopes.py 67.46% <43.47%> (-22.70%) ⬇️

... and 58 files with indirect coverage changes

Flag Coverage Δ
COMMON 42.77% <ø> (+0.03%) ⬆️
ONNX 34.77% <45.83%> (+<0.01%) ⬆️
OPENVINO ∅ <ø> (∅)
TENSORFLOW 29.59% <33.33%> (-0.06%) ⬇️
TORCH 66.00% <45.83%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.10% <ø> (-0.66%) ⬇️
torch 93.43% <ø> (ø)
tensorflow 93.72% <ø> (-0.24%) ⬇️
onnx 93.05% <ø> (ø)
openvino 25.58% <ø> (-68.49%) ⬇️
ptq 67.31% <ø> (-20.43%) ⬇️

@alexsu52 alexsu52 merged commit de46194 into openvinotoolkit:develop Mar 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Public API-impacting changes NNCF Common Pull request that updates NNCF Common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants