Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andreyan/awq extention #2708

Merged
merged 10 commits into from
Jun 17, 2024

Conversation

andreyanufr
Copy link
Collaborator

Changes

Extended AWQ algorithms for patterns Act->MatMul and Act->Multiply->MatMul with insertion for extra scales after activation.

Reason for changes

Support AWQ for wider family of LLMs

Related tickets

CVS-141131

Tests

Added unit tests

@andreyanufr andreyanufr requested a review from a team as a code owner May 29, 2024 09:07
@github-actions github-actions bot added NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PTQ Pull requests that updates NNCF PTQ labels May 29, 2024
@ljaljushkin
Copy link
Contributor

Could you post a job number with install and weight compression tests? Just to make sure it doesn't lead to degradation.

@alexsu52 alexsu52 requested a review from KodiaqQ June 10, 2024 04:18
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 98.52941% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.18%. Comparing base (90a7f0d) to head (829087f).
Report is 24 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2708       +/-   ##
============================================
+ Coverage    47.12%   91.18%   +44.06%     
============================================
  Files          479      483        +4     
  Lines        46072    46412      +340     
============================================
+ Hits         21712    42323    +20611     
+ Misses       24360     4089    -20271     
Files Coverage Δ
...tion/algorithms/weight_compression/awq_patterns.py 100.00% <100.00%> (ø)
...ntization/algorithms/weight_compression/backend.py 100.00% <100.00%> (ø)
.../algorithms/weight_compression/openvino_backend.py 98.85% <100.00%> (+0.14%) ⬆️
.../quantization/algorithms/weight_compression/awq.py 91.01% <96.55%> (+0.21%) ⬆️

... and 339 files with indirect coverage changes

Flag Coverage Δ
COMMON 41.87% <0.00%> (-1.70%) ⬇️
ONNX 34.15% <0.00%> (-0.60%) ⬇️
OPENVINO 40.91% <98.52%> (+0.97%) ⬆️
TENSORFLOW 29.39% <0.00%> (?)
TORCH 65.36% <5.88%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.55% <ø> (+23.93%) ⬆️
torch 93.65% <ø> (+60.47%) ⬆️
tensorflow 93.26% <ø> (+93.26%) ⬆️
onnx 93.06% <ø> (+<0.01%) ⬆️
openvino 94.51% <100.00%> (+0.35%) ⬆️
ptq 90.50% <98.52%> (+11.09%) ⬆️

Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreyanufr andreyanufr requested a review from KodiaqQ June 17, 2024 11:52
@KodiaqQ KodiaqQ merged commit 0c22c2c into openvinotoolkit:develop Jun 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants