Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fail pipeline on improvement metric #2728

Merged

Conversation

AlexanderDokuchaev
Copy link
Collaborator

@AlexanderDokuchaev AlexanderDokuchaev commented Jun 11, 2024

Changes

Fail test pipeline in case of improvement if target metric improves

Reason for changes

To catch unexpected changes.

@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner June 11, 2024 19:14
@AlexanderDokuchaev AlexanderDokuchaev changed the title Fail pipeline on improvement metric [CI] Fail pipeline on improvement metric Jun 11, 2024
@github-actions github-actions bot added the NNCF PTQ Pull requests that updates NNCF PTQ label Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.90%. Comparing base (65c9515) to head (4364168).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2728   +/-   ##
========================================
  Coverage    47.90%   47.90%           
========================================
  Files          486      487    +1     
  Lines        46831    46839    +8     
========================================
+ Hits         22433    22440    +7     
- Misses       24398    24399    +1     

see 3 files with indirect coverage changes

Flag Coverage Δ
COMMON 42.56% <ø> (ø)
ONNX 34.32% <ø> (+<0.01%) ⬆️
OPENVINO 40.82% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 69.61% <ø> (ø)
torch 33.21% <ø> (+0.02%) ⬆️
tensorflow 0.00% <ø> (ø)
onnx 93.05% <ø> (ø)
openvino 94.39% <ø> (ø)
ptq 80.91% <ø> (ø)

@AlexanderDokuchaev
Copy link
Collaborator Author

AlexanderDokuchaev commented Jun 11, 2024

manual/job/post_training_weight_compression/68 - fail with incorrect reference
manual/job/post_training_weight_compression/69 - pass

@KodiaqQ KodiaqQ merged commit 289fefc into openvinotoolkit:develop Jun 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants