Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align polynomial scheduler with other schedulers #549

Merged

Conversation

andrey-churkin
Copy link
Contributor

@andrey-churkin andrey-churkin commented Mar 4, 2021

When we use the polynomial scheduler with "sparsity_target_epoch": 0 and "update_per_optimizer_step": true we get that sparsity_target value is reached at step 0 of the 1st epoch.

polynomial

This behavior does not correspond to the sparsity_target_epoch parameter description:

nncf/nncf/config/schema.py

Lines 513 to 515 in 4189d09

"sparsity_target_epoch": with_attributes(_NUMBER,
description="Index of the epoch from which the sparsity level "
"of the model will be equal to spatsity_target value"),

Also, this behavior is different from other schedulers. This PR fixes it.

@vshampor
Copy link
Contributor

vshampor commented Mar 5, 2021

@andrey-churkin please fix the merge conflicts.

@andrey-churkin
Copy link
Contributor Author

@andrey-churkin please fix the merge conflicts.

Done.

@vshampor vshampor merged commit 77c1e54 into openvinotoolkit:develop Mar 5, 2021
kshpv pushed a commit to kshpv/nncf that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants