Pylint2.10 update #937
Merged
Pylint2.10 update #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
4 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
github-actions
bot
added
the
dependencies
|
Jenkins please retry a build |
ljaljushkin
requested changes
Sep 20, 2021
nncf/torch/layers.py
Outdated
| @@ -96,6 +96,7 @@ def _custom_forward_fn(self, input_): | |||
| proxy_weight = self.weight | |||
| return self._conv_forward(input_, proxy_weight, proxy_padding_value) | |||
|
|
|||
| # pylint: disable=W0237 | |||
There was a problem hiding this comment.
I think the _conv_forward function shouldn't have the same name as in the original implementation of Conv2d.
The warning should be resolved by simply renaming this method to something different, e.g. _conv_forward_proxy
There was a problem hiding this comment.
Ok, i'll change the name of this function
…nto pylint2.10_update
|
Jenkins please retry a build |
ljaljushkin
approved these changes
Sep 24, 2021
Closed
vshampor
pushed a commit
that referenced
this pull request
Oct 11, 2021
* fixed all issues in examples folder for pylint 2.10 update * fixed some pylint warnings in tests and nncf folders * fixed pylint warnings in tools folder + setup.py file * fixed parameter naming in synthetic.py * forgot to pass file in json.load() * added pylint flags * disabled high-priority warnings in tests and fixed low-priority warnings * fixed issues with iteration * fixed issue with checkpoint_loading * tried to fix pylint issues with bad option values * fixed disable flag in examples/tensorflow/common/callbacks.py * fixed disable flag in examples/tensorflow/common/callbacks.py
kshpv
pushed a commit
to kshpv/nncf
that referenced
this pull request
Oct 11, 2022
* fixed all issues in examples folder for pylint 2.10 update * fixed some pylint warnings in tests and nncf folders * fixed pylint warnings in tools folder + setup.py file * fixed parameter naming in synthetic.py * forgot to pass file in json.load() * added pylint flags * disabled high-priority warnings in tests and fixed low-priority warnings * fixed issues with iteration * fixed issue with checkpoint_loading * tried to fix pylint issues with bad option values * fixed disable flag in examples/tensorflow/common/callbacks.py * fixed disable flag in examples/tensorflow/common/callbacks.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made fixes to resolve pylint 2.10 warnings.