-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix flops calculation for grouped convolutions #964
Merged
alexsu52
merged 2 commits into
openvinotoolkit:develop
from
evgeniya-egupova:fix_flops_calculation_for_grouped_convs
Oct 8, 2021
Merged
fix flops calculation for grouped convolutions #964
alexsu52
merged 2 commits into
openvinotoolkit:develop
from
evgeniya-egupova:fix_flops_calculation_for_grouped_convs
Oct 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexKoff88
reviewed
Oct 5, 2021
@@ -306,9 +306,10 @@ def count_flops_and_weights_per_node(graph: NNCFGraph, | |||
name = node.node_name | |||
num_in_channels = input_channels.get(name, node.layer_attributes.in_channels) | |||
num_out_channels = output_channels.get(name, node.layer_attributes.out_channels) | |||
filters_per_channel = num_out_channels // node.layer_attributes.groups |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A part of TODO list for today
ljaljushkin
approved these changes
Oct 7, 2021
alexsu52
approved these changes
Oct 7, 2021
vshampor
pushed a commit
that referenced
this pull request
Oct 11, 2021
- fix flops calculation for grouped convolutions - add test with grouped convs
vshampor
pushed a commit
to vshampor/nncf
that referenced
this pull request
Oct 12, 2021
- fix flops calculation for grouped convolutions - add test with grouped convs
kshpv
pushed a commit
to kshpv/nncf
that referenced
this pull request
Oct 11, 2022
- fix flops calculation for grouped convolutions - add test with grouped convs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: