Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Main template not loding in /accounts/login/ #233

Closed
nemesifier opened this issue Dec 3, 2020 · 3 comments
Closed

[bug] Main template not loding in /accounts/login/ #233

nemesifier opened this issue Dec 3, 2020 · 3 comments

Comments

@nemesifier
Copy link
Member

nemesifier commented Dec 3, 2020

PS: this happens on a fresh installation of ansible-openwisp2 with the latest patches merged. At first I thought I was able to replicate it in the dev env of openwisp-users but subsequent attempts do not show the issue, I think this happens in ansible-openwisp2 and may be related to the order of INSTALLED_APPS.

Try to access /accounts/login/.

Something like the following screenshot is shown:

Screenshot from 2020-12-03 17-52-31

But we expect to see the main theme as in the URL which is used to confirm the email address.

Screenshot from 2020-12-03 17-53-03

This bug is triggered after confirming an email address.

@nemesifier nemesifier transferred this issue from openwisp/openwisp-users Dec 4, 2020
@nemesifier nemesifier moved this from Backlog to To do in OpenWISP Priorities for next releases Dec 4, 2020
@nemesifier nemesifier added bug important Higher priority or release blocker labels Dec 4, 2020
purhan added a commit to purhan/ansible-openwisp2 that referenced this issue Dec 5, 2020
purhan added a commit to purhan/ansible-openwisp2 that referenced this issue Dec 5, 2020
@purhan
Copy link
Contributor

purhan commented Dec 8, 2020

@nemesisdesign @pandafy I was able to replicate this in openwisp-controller, can you confirm this? Could this be related??

@pandafy
Copy link
Member

pandafy commented Dec 8, 2020

@purhan the issue originates from conflict in templates of openwisp-notifications, openwisp-users and openwisp-utils. Since the test project of openwisp-controlller uses all modules, it can be reproduced there.

Please read #235 (comment). If you still have any doubt, let me know.

@nemesifier
Copy link
Member Author

Meanwhile, I found that installing the development version of openwisp-users, which now has support for django-allauth==0.43.0, completely fixes this issue. We could make a point release if that's a feasible option.

I confirm this, thank you @purhan for pointing it out! I just tested it on an instance deployed with the latest ansible-openwisp2 and indeed it fixes the issue, so I released openwisp-users 0.5.1 and I think no further action is needed, let's close this.

OpenWISP Contributor's Board automation moved this from To do (general) to Done Dec 13, 2020
OpenWISP Priorities for next releases automation moved this from To do to Done Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug important Higher priority or release blocker
Development

Successfully merging a pull request may close this issue.

3 participants