[schema] Validate general hostname format #42

netjsonconfig/backends/openwrt/openwrt.py

@@ -7,7 +7,7 @@
 
 import six
 from jinja2 import Environment, PackageLoader
-from jsonschema import validate
+from jsonschema import FormatChecker, validate
 from jsonschema.exceptions import ValidationError as JsonSchemaError
 
 from . import renderers
@@ -130,7 +130,7 @@ def _render_files(self):
 
     def validate(self):
         try:
-            validate(self.config, self.schema)
+            validate(self.config, self.schema, format_checker=FormatChecker())
         except JsonSchemaError as e:
             raise ValidationError(e)
 

netjsonconfig/schema.py

@@ -629,6 +629,7 @@
                     "type": "string",
                     "maxLength": 63,
                     "minLength": 1,
+                    "format": "hostname",
                     "propertyOrder": 1,
                 },
                 "ula_prefix": {

tests/openwrt/test_formats.py

@@ -0,0 +1,17 @@
+import unittest
+
+from netjsonconfig import OpenWrt
+from netjsonconfig.exceptions import ValidationError
+from netjsonconfig.utils import _TabsMixin
+
+
+class TestFormats(unittest.TestCase, _TabsMixin):
+    maxDiff = None
+
+    def test_general_hostname(self):
+        o = OpenWrt({"general": {"hostname": "invalid hostname"}})
+        with self.assertRaises(ValidationError):
+            o.validate()
+        o.config['general']['hostname'] = 'valid'
+        o.validate()
+