Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform validation of formats #42

Open
nemesifier opened this issue Mar 11, 2016 · 2 comments
Open

Perform validation of formats #42

nemesifier opened this issue Mar 11, 2016 · 2 comments
Labels
enhancement

Comments

@nemesifier
Copy link
Member

See python-jsonschema: Validating Format.

With this we can enforce valid hostnames, ipv4, ipv6, and probably ipv4 and ipv6 networks too.
@nemesifier nemesifier added this to the 0.4 milestone Mar 11, 2016
@nemesifier nemesifier mentioned this issue Mar 22, 2016
Open
@nemesifier nemesifier modified the milestones: 0.4.1, 0.4 Mar 22, 2016
nemesifier added a commit that referenced this issue Apr 3, 2016
@nemesifier
[schema] Validate general hostname format #42
ef8c296
nemesifier added a commit that referenced this issue Apr 3, 2016
@nemesifier
[schema] Validate interface ipv4 address format #42
2f23cfd
nemesifier added a commit that referenced this issue Apr 3, 2016
@nemesifier
[OpenWrt] Validate ntp server hostname format #42
612959e
nemesifier added a commit that referenced this issue Apr 3, 2016
@nemesifier
[tests] Fixed invalid hostnames in various tests #42
abb63bd
nemesifier added a commit that referenced this issue Apr 4, 2016
@nemesifier
[schema] Validate dns_search hostname format #42
f1116f0
nemesifier added a commit that referenced this issue Apr 4, 2016
@nemesifier
[schema] Remove "format" definition from gateway #42
6facde7 
Too restrictive. Also allow gateway to be blank (so it can be ignored).
@nemesifier nemesifier modified the milestones: 0.5, 0.4.1 Apr 6, 2016
@nemesifier nemesifier removed this from the 0.5 milestone Dec 28, 2016
@jack17529
Copy link

@nemesisdesign is this issu still open to work?

@nemesifier
Copy link
Member Author

There''s more design decision needed, this extra validation can make the library too hard to work with web uis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nemesifier @jack17529