Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cannot use wpa3-personal for 802.11s mesh #254

Closed
SerialVelocity opened this issue Feb 26, 2023 · 6 comments · Fixed by #262
Closed

[BUG] Cannot use wpa3-personal for 802.11s mesh #254

SerialVelocity opened this issue Feb 26, 2023 · 6 comments · Fixed by #262

Comments

@SerialVelocity
Copy link

It seems wpa3-personal (not sure if mixed is possible as well) is missing from the schema:
https://github.com/openwisp/netjsonconfig/blob/1.0.2/netjsonconfig/schema.py#L400-L404

Is there a way of setting this manually and bypassing the checks? Usually, you can override fields by specifying "unknown properties" but the "encryption" key is re-used here.

@nemesifier
Copy link
Member

@SerialVelocity we need to add {"$ref": "#/definitions/encryption_wpa3_personal"}, plus a couple of tests for rendering and parsing.

@nemesifier nemesifier added this to To do (general) in OpenWISP Contributor's Board via automation Feb 28, 2023
@nemesifier nemesifier added this to Backlog in OpenWISP Priorities for next releases via automation Feb 28, 2023
@SerialVelocity
Copy link
Author

I think another issue is the 2 has been removed from:
https://github.com/openwisp/netjsonconfig/blob/1.0.2/netjsonconfig/schema.py#L496

which affects wpa2/wpa3 mixed mode. Quite a big issue if you have multiple SSIDs because if you have a WPA3 SSID with required 802.11w, and a WPA2/WPA3 mixed mode SSID with optional 802.11w, then your speed will drop from ~770Mbps to ~150Mbps.

@nemesifier
Copy link
Member

@SerialVelocity can you look whether this patch correctly adds support for WPA3 in mesh mode?

#262

I think another issue is the 2 has been removed from: https://github.com/openwisp/netjsonconfig/blob/1.0.2/netjsonconfig/schema.py#L496

which affects wpa2/wpa3 mixed mode. Quite a big issue if you have multiple SSIDs because if you have a WPA3 SSID with required 802.11w, and a WPA2/WPA3 mixed mode SSID with optional 802.11w, then your speed will drop from ~770Mbps to ~150Mbps.

Doesn't mfp have to be optional in mixed mode? Can it be required and work on WPA2 too? Not sure I understood 100%.

@SerialVelocity
Copy link
Author

I think it adds it correctly. I'm running the docker images of openwisp so I'm not sure how to try deploying your patch.

Afaik, the "pmf is required" extension came before wpa3 was a thing:
https://en.wikipedia.org/wiki/IEEE_802.11w-2009

I can't find anywhere that says pmf has to be optional for mixed mode as it can already be required for just wpa2. Could you point me to where you have seen that be the case? (I haven't explicitly tried connecting with wpa2 when mixed mode is enabled and pmfs are required)

@nemesifier
Copy link
Member

I think it adds it correctly. I'm running the docker images of openwisp so I'm not sure how to try deploying your patch.

Afaik, the "pmf is required" extension came before wpa3 was a thing: https://en.wikipedia.org/wiki/IEEE_802.11w-2009

I can't find anywhere that says pmf has to be optional for mixed mode as it can already be required for just wpa2. Could you point me to where you have seen that be the case? (I haven't explicitly tried connecting with wpa2 when mixed mode is enabled and pmfs are required)

I can't find the information anymore right now, can you please create a separate issue for this other subject? We should look at what LuCI (the web interface of OpenWrt) does and just follow along.

@SerialVelocity
Copy link
Author

Done!

nemesifier added a commit that referenced this issue May 2, 2023
Closes #254

Co-authored-by: Federico Capoano <f.capoano@openwisp.io>
OpenWISP Contributor's Board automation moved this from To do (general) to Done May 2, 2023
OpenWISP Priorities for next releases automation moved this from Backlog to Done May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants