WIP: Improve openwisp-uci-autoname.lua script #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
okraits
force-pushed
the
tdt-uci-autoname
branch
from
973df9e
to
8f39b5f
Compare
okraits
force-pushed
the
tdt-uci-autoname
branch
from
e464e07
to
d2566b8
Compare
okraits
force-pushed
the
tdt-uci-autoname
branch
from
bb5aca8
to
65c4fb9
Compare
okraits
force-pushed
the
tdt-uci-autoname
branch
from
f35fb95
to
597bd60
Compare
|
@nemesisdesign I'm done - please review. |
nemesifier
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to work on the
openwisp-uci-autoname.luascript for #38 and fixed a lot of warnings from luacheck in the script and inutils.lua. Then I fixed some more warnings to repair the unit tests.There are still a lot of warnings from luacheck. But I will carry on with the main issues first.