Remove unmanaged settings from the default configuration #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
reviewed
Sep 24, 2018
There was a problem hiding this comment.
@okraits looks good!
A couple minor improvements: I'd add somewhere an explicit phrase which says that by default there are no unmanaged configurations.
See my comment.. ;-)
README.rst
Outdated
| @@ -152,12 +152,12 @@ If the exit code of the executable script is higher than ``0`` the test will be | |||
| Unmanaged Configurations | |||
| ------------------------ | |||
|
|
|||
| In some cases it is necessary to ensure that some configuration sections won't be | |||
| In some cases it could necessary to ensure that some configuration sections won't be | |||
There was a problem hiding this comment.
I corrected the sentence and added a sentence about the unmanaged settings not being in the default configuration.
okraits
force-pushed
the
tdt-unmanaged
branch
from
d1335ba
to
e4fa100
Compare
okraits
force-pushed
the
tdt-unmanaged
branch
from
e4fa100
to
c8e3330
Compare
nemesifier
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.