Added Luacheck and travis.yml with install-config #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
requested changes
Nov 11, 2018
There was a problem hiding this comment.
@vishalx360 great progress and great work 👍
But there are two outstanding issues, shouldn't be hard to fix, see my comments below.
openwisp#77 - added travis.yml with dependencies installation script. - added luacheck test command in runtests script. - fixed accessing undefined variable `uci` warning Fixes openwisp#77
nemesifier
approved these changes
Nov 11, 2018
There was a problem hiding this comment.
Great work @vishalx360! This is very useful. Keep up the good work and I hope you learnt how we work so you can keep in mind all these suggestions for your next patches and they'll be merged much faster.
@okraits habemus travis on openwisp-config! 😁
|
@vishalx360 @nemesisdesign Great work guys! 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files added/changed - Summary
added travis.yml with dependencies installation configuration.
added luacheck test command with parameters (-d -a -r) to filter unwanted warnings in runtests script
after running runtests script
-- fixed
accessing undefined variable uciwarning by makinguciglobal variable and assigning torequire('uci')inopenwisp-config/tests/test_utils.luafilefixes #77
this is a submission for GCI task- Add travis-ci configuration for luacheck - OpenWISP