Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qa] Added commit message syle check #84 #85

Merged
merged 1 commit into from
Dec 9, 2018
Merged

[qa] Added commit message syle check #84 #85

merged 1 commit into from
Dec 9, 2018

Conversation

ppabcd
Copy link
Contributor

@ppabcd ppabcd commented Dec 5, 2018

Fixes #84

nemesifier
nemesifier requested changes Dec 6, 2018
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address my comment so I can merge 😊

.travis.yml Outdated
@@ -8,6 +8,15 @@ before_install:

install:
- sudo luarocks install luacheck
- pip install --no-cache-dir -U -r requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install openwisp-utils[qa]>=0.2.1 directly here and remove requirements.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all done

@nemesifier nemesifier merged commit 8509018 into openwisp:master Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppabcd @nemesifier