-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add a device name changed signal, connect it to refresh the notifications cache #361
Labels
Comments
PS: there's already a few lines of code which find out if the name has changed: openwisp-controller/openwisp_controller/config/base/device.py Lines 114 to 115 in a627b61
We can change the implementation to be like #241, which doesn't need an extra DB query which could be good to optimize the system a bit. |
This is ready to be worked on, depends on openwisp/openwisp-notifications#168 which is ready, so that branch can be installed by editing the requirements.txt this way:
|
I would like to work on it. |
codesankalp
added a commit
to codesankalp/openwisp-controller
that referenced
this issue
Mar 13, 2021
Added `device_name_changed` signal and connect it to refresh the notifications cache. Closes openwisp#361
codesankalp
added a commit
to codesankalp/openwisp-controller
that referenced
this issue
Mar 21, 2021
Added `device_name_changed` signal and connect it to refresh the notifications cache. Closes openwisp#361
codesankalp
added a commit
to codesankalp/openwisp-controller
that referenced
this issue
Mar 26, 2021
Added `device_name_changed` signal and connect it to refresh the notifications cache. Closes openwisp#361
nemesifier
pushed a commit
that referenced
this issue
Apr 3, 2021
Added `device_name_changed` signal. Connected it to a receiver which refreshes the notifications cache. Closes #361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Blocked by openwisp/openwisp-notifications#164.
We should first confirm that openwisp/openwisp-notifications#164 can be done and then we can move on with this.
Like #241 but emitted when the name is changed.
PS: there's already a few lines of code which find out if the name has changed:
openwisp-controller/openwisp_controller/config/base/device.py
Lines 114 to 115 in a627b61
We can change the implementation to be like #241, which doesn't need an extra DB query which could be good to optimize the system a bit.
Addendum
I want to make clear what the issue is: right now the issue is that when the name of a device is changed, the notifications keep referring to it with the old name.
When a new device registers, it registers using the mac address as the name, then an operator usually changes its name to something more human readable, but the notification keep referring to it with the mac address.
The text was updated successfully, but these errors were encountered: