-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ssh] Decoding the output of the sysupgrade command fails with UnicodeDecodeError #370
Comments
if I remember correctly,
I don't remember now, it may be that the returned value is
I didn't account for this failure. |
Yeah, I was also thinking about converting this to logging.
I will have a look into it.
I didn't mean that as an accusation. Thank you for your great work! I'll try to come up with a PR for this. |
I did a firmware upgrade with openwisp-firmware-upgrader. It was successful, but I got the following exception twice:
Due to
sysupgrade -v
, the verbose output of sysupgrade is decoded and that fails because of some byte.https://github.com/openwisp/openwisp-controller/blob/master/openwisp_controller/connection/connectors/ssh.py#L136
Just some thoughts:
Why do we print out the output?
Why do we decode it?
Why don't we catch exceptions there?
The text was updated successfully, but these errors were encountered: