Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the serializer classes of geo model API to a separate file #414

Closed
ManishShah120 opened this issue Apr 1, 2021 · 0 comments · Fixed by #416
Closed

Move the serializer classes of geo model API to a separate file #414

ManishShah120 opened this issue Apr 1, 2021 · 0 comments · Fixed by #416
Assignees
@ManishShah120
Labels
enhancement

Comments

@ManishShah120
Copy link
Member

Currently, the serializer classes of the geo model API are present in the views file. We should move the serializer classes to a separate serializers.py file.

openwisp-controller/openwisp_controller/geo/api/views.py

Line 24 in 9916774

class LocationSerializer(gis_serializers.GeoFeatureModelSerializer):

@ManishShah120 ManishShah120 self-assigned this Apr 1, 2021
ManishShah120 added a commit to ManishShah120/openwisp-controller that referenced this issue Apr 2, 2021
@ManishShah120
[change] Separated the serializer classes from views openwisp#414
b0a91ce 
- Moved the serializer classes from views.py file to a separate serializers.py file.

closes openwisp#414
@ManishShah120 ManishShah120 mentioned this issue Apr 2, 2021
Merged
nemesifier pushed a commit that referenced this issue Apr 6, 2021
@ManishShah120
[change] Separated the serializer classes from views #414
7806457 
Closes #414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManishShah120 ManishShah120

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[change] Separated the serializer classes from views #414 ManishShah120/openwisp-controller
1 participant
@ManishShah120