Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Popup never closes #439

Closed
atb00ker opened this issue Apr 23, 2021 · 6 comments · Fixed by #603
Closed

[bug] Popup never closes #439

atb00ker opened this issue Apr 23, 2021 · 6 comments · Fixed by #603
Labels
bug Good first issue Easy issue that new contributors may like to pick up to get themselves familiar with the repository.
Projects
OpenWISP Contributor's Board OpenWISP Priorities for next releases

Comments

@atb00ker
Copy link
Member

atb00ker commented Apr 23, 2021 •
edited
Loading

When I create a new connection credentials successfully, the popup never closes it gets stuck on "Closing Popup..."
Steps to reproduce:

  1. Go to a device configuration change page and switch to the connections tab.
  2. Press + to create a new connection
  3. Fill correct details to fill the credential
  4. Hit save and notice while credentials are saved, popup remains open.
@atb00ker atb00ker added the bug label Apr 23, 2021
@atb00ker atb00ker added this to To do (general) in OpenWISP Contributor's Board via automation Apr 23, 2021
@nemesifier nemesifier added this to Backlog in OpenWISP Priorities for next releases via automation Jan 25, 2022
@nemesifier nemesifier moved this from Backlog to To do in OpenWISP Priorities for next releases Jan 25, 2022
@atb00ker atb00ker moved this from To do (general) to To do (documentation) in OpenWISP Contributor's Board Jan 31, 2022
@atb00ker atb00ker moved this from To do (documentation) to To do (ansible/docker) in OpenWISP Contributor's Board Jan 31, 2022
@atb00ker atb00ker added the Good first issue Easy issue that new contributors may like to pick up to get themselves familiar with the repository. label Jan 31, 2022
@atb00ker atb00ker moved this from To do (ansible/docker) to To do (Python & Django) in OpenWISP Contributor's Board Jan 31, 2022
@yashikajotwani12
Copy link
Contributor

I would like to work on this.

@atb00ker
Copy link
Member Author

atb00ker commented Feb 4, 2022

Hey @yashikajotwani12 ,

Feel free to pick it, no assignment or permission required! 😄

@saieswar13
Copy link

Is this issue still open, can I work on this issue?

@yashikajotwani12
Copy link
Contributor

Is this issue still open, can I work on this issue?

Hey @saieswar13, I am working on this, can you take another issue, thanks.

@yashikajotwani12
Copy link
Contributor

yashikajotwani12 commented Feb 15, 2022 •
edited
Loading

Before:
Recording 2022-02-15 at 18 20 25

After:
Recording 2022-02-15 at 18 25 54

Hello! I have made changes in virtual env's file widget.js

 // var name = windowname_to_id(win.name);
                var elem = $('#' + win.name);

so like how I should change it actually to make it work like this?

Screenshot from 2022-02-15 18-43-43

@pandafy
Copy link
Member

pandafy commented Feb 15, 2022

Thank you @yashikajotwani12 for debugging this. This issue has been fixed in the latest version of django-sortedm2m library. We only need to update the dependency version here.

yashikajotwani12 added a commit to yashikajotwani12/openwisp-controller that referenced this issue Feb 15, 2022
@yashikajotwani12
[bug] Popup never closes openwisp#439
d8df58f 
Fixes openwisp#439
@yashikajotwani12 yashikajotwani12 mentioned this issue Feb 15, 2022
Merged
pandafy pushed a commit to yashikajotwani12/openwisp-controller that referenced this issue Feb 15, 2022
@yashikajotwani12 @pandafy
[deps] Upgraded dependencies openwisp#439
676e813 
- Bumped django-taggit~=2.1.0
- Bumped scp~=0.14.2
- Bumped django-sortedm2m~=3.1.1

Test dependencies:
- pytest-django~=4.5.2
- Bumped redis~=4.1.2
- Bumped mock-ssh-server~=0.9.1

Related to openwisp#439
OpenWISP Contributor's Board automation moved this from To do (Python & Django) to Done Feb 15, 2022
nemesifier pushed a commit that referenced this issue Feb 15, 2022
@yashikajotwani12
[deps] Upgraded dependencies #439
dd6fd95 
- Bumped django-taggit~=2.1.0
- Bumped scp~=0.14.2
- Bumped django-sortedm2m~=3.1.1

Test dependencies:
- pytest-django~=4.5.2
- Bumped redis~=4.1.2
- Bumped mock-ssh-server~=0.9.1

Removed coverage dependency because it's defined in openwisp-utils.

Closes #439
OpenWISP Priorities for next releases automation moved this from To do to Done Feb 15, 2022
codesankalp pushed a commit that referenced this issue Apr 21, 2022
@yashikajotwani12 @codesankalp
[deps] Upgraded dependencies #439
e4066d1 
- Bumped django-taggit~=2.1.0
- Bumped scp~=0.14.2
- Bumped django-sortedm2m~=3.1.1

Test dependencies:
- pytest-django~=4.5.2
- Bumped redis~=4.1.2
- Bumped mock-ssh-server~=0.9.1

Removed coverage dependency because it's defined in openwisp-utils.

Closes #439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Good first issue Easy issue that new contributors may like to pick up to get themselves familiar with the repository.
Projects
OpenWISP Contributor's Board
  
Done
OpenWISP Priorities for next releases
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Popup never closes #439 yashikajotwani12/openwisp-controller
4 participants
@atb00ker @pandafy @yashikajotwani12 @saieswar13