Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Change device location API endpoint again #460

Closed
nemesifier opened this issue May 17, 2021 · 3 comments · Fixed by #483
Closed

[API] Change device location API endpoint again #460

nemesifier opened this issue May 17, 2021 · 3 comments · Fixed by #483

Comments

@nemesifier
Copy link
Member

nemesifier commented May 17, 2021

We should change this again to make it consistent: /device/{id}/location > ​/controller​/device​/{id}/location/.

We should maintain the old URL for backward compatibility.

@atb00ker @ManishShah120 is there a way to avoid showing the old URL in the API docs but keeping it around for backward compatibility until the next version?

PS: I also noticed we have some URLs prefixed with location, to maintain consistency we should name these:

  • /controller/location/
@atb00ker
Copy link
Member

Sounds good!

is there a way to avoid showing the old URL in the API docs but keeping it around for backward compatibility until the next version?

Will need to check if swagger has something like that! 😄

@ManishShah120 ManishShah120 self-assigned this May 21, 2021
@nemesifier nemesifier moved this from To do to In progress in [GSoC 2021] OpenWISP REST API Jun 1, 2021
@nemesifier nemesifier moved this from In progress to To do in [GSoC 2021] OpenWISP REST API Jun 1, 2021
@nemesifier nemesifier added the Important Higher priority or release blocker label Jun 1, 2021
@ManishShah120
Copy link
Member

PS: I also noticed we have some URLs prefixed with location, to maintain consistency we should name these:

  • /controller/location/

Hi, @nemesisdesign Did you mean to change the endpoints name to controller_location

@atb00ker
Copy link
Member

atb00ker commented Jun 4, 2021

I think he means change <host>/location/ -> <host>/controller/location/.

ManishShah120 added a commit that referenced this issue Jun 4, 2021
ManishShah120 added a commit that referenced this issue Jun 4, 2021
ManishShah120 added a commit that referenced this issue Jun 9, 2021
OpenWISP Priorities for next releases automation moved this from Backlog to Done Jun 9, 2021
nemesifier pushed a commit that referenced this issue Jun 9, 2021
[GSoC 2021] OpenWISP REST API automation moved this from To do to Done Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Important Higher priority or release blocker
Development

Successfully merging a pull request may close this issue.

3 participants