Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qa] Enable css and js linting checks #487

Closed
niteshsinha17 opened this issue Jun 10, 2021 · 5 comments · Fixed by #576
Closed

[qa] Enable css and js linting checks #487

niteshsinha17 opened this issue Jun 10, 2021 · 5 comments · Fixed by #576
Labels
Good first issue Easy issue that new contributors may like to pick up to get themselves familiar with the repository. Hacktoberfest Easy issues for attracting Hacktoberfest participants.

Comments

@niteshsinha17
Copy link
Member

CSS and Js linting checks are disabled by default from openwisp-qa-check. Check this https://github.com/openwisp/openwisp-utils/#openwisp-qa-check and enable it for controller and remove changes made in #376 related to linting checks. Update readme too.
@niteshsinha17 niteshsinha17 added the Good first issue Easy issue that new contributors may like to pick up to get themselves familiar with the repository. label Jun 10, 2021
@Red-0111
Copy link

Hi, I would like to work on this issue, please tell me how to proceed :)

@harsh7in
Copy link

hi, @niteshsinha17 I want to work on this issue. Can I proceed ?

@nemesifier
Copy link
Member

CSS and Js linting checks are disabled by default from openwisp-qa-check. Check this https://github.com/openwisp/openwisp-utils/#openwisp-qa-check and enable it for controller and remove changes made in #376 related to linting checks. Update readme too.

@niteshsinha17 can you please refresh my mind about what has to be done here? Do we need to just switch to the linting done by openwisp-utils and remove any custom linting done in this repo?

@niteshsinha17
Copy link
Member Author

@nemesisdesign Yes, you are right. @harsh-9in go ahead 😄

@nemesifier nemesifier added the Hacktoberfest Easy issues for attracting Hacktoberfest participants. label Sep 28, 2021
yashikajotwani12 added a commit to yashikajotwani12/openwisp-controller that referenced this issue Dec 4, 2021
@yashikajotwani12
[qa] Enable css and js linting checks openwisp#487
f6f0c5d 
Fixes openwisp#487
@yashikajotwani12 yashikajotwani12 mentioned this issue Dec 4, 2021
Merged
@ashwini-m-hub
Copy link

still open can I do it

yashikajotwani12 added a commit to yashikajotwani12/openwisp-controller that referenced this issue Jan 18, 2022
@yashikajotwani12
[qa] Enable css and js linting checks openwisp#487
8cd19ef 
Fixes openwisp#487
yashikajotwani12 added a commit to yashikajotwani12/openwisp-controller that referenced this issue Jan 19, 2022
@yashikajotwani12
[qa] Enable css and js linting checks openwisp#487
6ffbc9d 
Fixes openwisp#487
yashikajotwani12 added a commit to yashikajotwani12/openwisp-controller that referenced this issue Feb 12, 2022
@yashikajotwani12
[qa] Enable css and js linting checks openwisp#487
faa156e 
Fixes openwisp#487
yashikajotwani12 added a commit to yashikajotwani12/openwisp-controller that referenced this issue Feb 12, 2022
@yashikajotwani12
[qa] Enable css and js linting checks openwisp#487
fae6852 
Fixes openwisp#487
yashikajotwani12 added a commit to yashikajotwani12/openwisp-controller that referenced this issue Feb 12, 2022
@yashikajotwani12
[qa] Enable css and js linting checks openwisp#487
81739cf 
Fixes openwisp#487
yashikajotwani12 added a commit to yashikajotwani12/openwisp-controller that referenced this issue Feb 12, 2022
@yashikajotwani12
[qa] Enable css and js linting checks openwisp#487
840ca7a 
Fixes openwisp#487
nemesifier pushed a commit that referenced this issue Feb 12, 2022
@yashikajotwani12
[ci] QA: Enabled css and js linting checks #487
f989c96 
Closes #487
codesankalp pushed a commit that referenced this issue Apr 21, 2022
@yashikajotwani12 @codesankalp
[ci] QA: Enabled css and js linting checks #487
6689b4d 
Closes #487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Easy issue that new contributors may like to pick up to get themselves familiar with the repository. Hacktoberfest Easy issues for attracting Hacktoberfest participants.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[qa] Enable css and js linting checks #487 yashikajotwani12/openwisp-controller
5 participants
@nemesifier @niteshsinha17 @harsh7in @ashwini-m-hub @Red-0111