[models] Use hardware_id as string representation if that feature is enabled #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
reviewed
Jun 23, 2019
openwisp_controller/config/models.py
Outdated
| @@ -99,6 +99,12 @@ class Meta(AbstractDevice.Meta): | |||
| ) | |||
| abstract = False | |||
|
|
|||
| def __str__(self): | |||
| if app_settings.HARDWARE_ID_ENABLED: | |||
There was a problem hiding this comment.
I'd switch to a oneliner to avoid code coverage decreasing:
return self.hardware_id if app_settings.HARDWARE_ID_ENABLED else self.nameThere was a problem hiding this comment.
@nemesisdesign Thank you for the hint - done! 😀
okraits
force-pushed
the
tdt-device-string
branch
from
4da5e21
to
58f7394
Compare
|
@nemesisdesign Anything blocking this from a merge? |
nemesifier
approved these changes
Jul 12, 2019
|
@okraits thx for reminding me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hardware_id should be used as the string representation for a device if the hardware_id feature is enabled.