Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] Moving urls to admin namespace #116

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

atb00ker
Copy link
Member

@atb00ker atb00ker commented Aug 1, 2019

No description provided.

openwisp_controller/config/apps.py Outdated Show resolved Hide resolved
@atb00ker atb00ker force-pushed the namespace branch 4 times, most recently from 19a1b6d to 758af81 Compare August 7, 2019 18:42
@atb00ker
Copy link
Member Author

atb00ker commented Aug 7, 2019

Python3.4 is deprecated and Twisted doesn't support 3.4 anymore!
Moreover, default container for travis is now xenial and hence the tests are failling.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atb00ker should I restart the build or what? I'm going to restart it now. The PR looks good 👍
Let me know what we should do to fix the build.

@coveralls
Copy link

coveralls commented Aug 17, 2019

Coverage Status

Coverage remained the same at 98.203% when pulling 0091114 on atb00ker:namespace into 077387e on openwisp:master.

@atb00ker
Copy link
Member Author

@atb00ker should I restart the build or what? I'm going to restart it now. The PR looks good Let me know what we should do to fix the build.

Just needed to be rebased to upgrade from python3.4 to python3.5.
All good now! 😄

@nemesifier nemesifier merged commit 1747940 into openwisp:master Aug 21, 2019
@atb00ker atb00ker deleted the namespace branch April 4, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants