Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Travis] Added support for newer versions of Ubuntu #130

Merged
merged 1 commit into from Dec 5, 2019
Merged

[Travis] Added support for newer versions of Ubuntu #130

merged 1 commit into from Dec 5, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 3, 2019

Added support for newer versions of ubuntu.
Fixes #119

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.187% when pulling 6d7b138a248ac3aee04137a04b507cb92415b50b on Weirdo914:master into 28e2d7a on openwisp:master.

@coveralls
Copy link

coveralls commented Dec 3, 2019

Coverage Status

Coverage remained the same at 98.187% when pulling 12bb944 on Weirdo914:master into 28e2d7a on openwisp:master.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good except for one minor details, see below.

.travis.yml Outdated
@@ -61,4 +63,4 @@ script:
fi

after_success:
pipenv run coveralls
pipenv run coveralls
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should not have been changed, configure your editor to always add a new line at the end of the file, edit this file again (ensure there's a new line at the end) and amend the commit with git commit --amend, make sure this line is unchanged.

Please read carefully our contributing guidelines, especially the following section: http://openwisp.io/docs/developer/contributing.html#avoiding-unnecessary-changes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it

Added support for newer versions of ubuntu.
Fixes #119
@nemesifier nemesifier merged commit e7d116a into openwisp:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[travis] Add support for newer version of ubuntu
3 participants