Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Updated travis.yml file #132

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Conversation

a09hopper
Copy link
Contributor

Updated travis.yml to remove warnings and also updated commit name to stop travis from failing

@coveralls
Copy link

coveralls commented Dec 3, 2019

Coverage Status

Coverage remained the same at 98.187% when pulling 77907a3 on a09hopper:master into 28e2d7a on openwisp:master.

@EdgeKing810
Copy link
Contributor

Squash your commits into one only @a09hopper

@a09hopper a09hopper force-pushed the master branch 2 times, most recently from be74119 to f432a65 Compare December 3, 2019 17:08
Copy link
Member

@atb00ker atb00ker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Small changes requested, the commit message now looks fine! 😄

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@2stacks
Copy link
Member

2stacks commented Dec 3, 2019

You should squash the two commits so you're left with only the intended change.

[travis] Corrected this file

Added back all the info and only fixed the warning
@a09hopper
Copy link
Contributor Author

the commits have been squashed

@dwang
Copy link

dwang commented Dec 3, 2019

LGTM 👍

@atb00ker atb00ker self-requested a review December 4, 2019 08:06
@nemesifier nemesifier merged commit 5e81478 into openwisp:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants