Implement pipenv tasks to #38 #55
Conversation
There was a problem hiding this comment.
@anonguy great, now you see the travis build failing and you can try editing .travis.yml to make it pass, once done please squash your commits (except the one of @okraits) into one and use a commit message that follows our commit message guidelines.
There was a problem hiding this comment.
I just restarted the build on the master branch and it passed regularly: https://travis-ci.org/openwisp/openwisp-controller/jobs/450308174
I'm not 100% sure of what is happening becaus I'm not familiar with pipenv, but by looking at the errors we are getting in the failing build I can think it's because one of the dependencies, probably django-netjsonconfig is not being installed as we need right now in the dev branch, we need to get the latest master of django-netjsonconfig.
You can verify this on your local machine by doing the following:
- install the latest version of django-netjsonconfig available on pypi in the pipenv
- now run tests on openwisp-controller (ensure the latest stable version of django-netjsonconfig is being used)
If you see similar failures, that's the reason
Implemented pipenv scripts to the relevant section of the Pipfile, to replace existing files. "runflake8" is replaced by "pipenv run lint", and "runisort" is replaced by "pipenv run isort". Since it's difficult to implement runtests.py as a single one-liner, I've added "pipenv run test", which is an alias to "pipenv run python runtests.py".
|
I've addressed all issues, fixed the travis configuration to pass build tests, and squashed all commits into a single commit that passes commit message guidelines. |
|
Great job! 👍 Thank you very much for your huge effort! |
This PR implements pipenv tasks for linting and testing of code, building on the
Pipfilefrom #38.