[x509] Fix certificates without organization assigned #34

[shashwat1002]

This code effectively, overrides the save() function of Cert to check for a corresponding device every time a Certificate is created and then checks for the organization of that device and updates the cert object accordingly and saves it.

[coveralls]

Coverage remained the same at 99.588% when pulling 9ac2ea2 on shashwat1002:issue#34_autgen_cert into 36663df on openwisp:master.

[nemesifier]

Test is missing.

This is not the right place where to put this code, you can delete it entirely.
Write a test failing first that replicates the issue I described in #34.

You have to dig deeper and find where the auto-cert feature is written in django-netjsonconfig, override that method here and solve the issue.

Keep in mind the commit message must explicitly say Closes #34 at the end of the commit message to use the auto-close feature of github, so please adhere strictly to our commit guidelines.

[atb00ker]

How is this for the commit head?
[x509] Auto-generated cert for object without org
Inside the square brackets, we usually want to classify the pull request ! 😄

[nemesifier]

@shashwat1002 great progress! 👍

I tested to ensure the test fails without your fix and it does, so that's good!

I need to ask you some final adjustments before I'm able to merge:

• the commit message is too complicated and long, please change it to the following:

[vpn-client] Fixed auto-certificates without organization #34 

This bug happened only with shared VPNs and shared VPN-client templates.
Fixes #34

• see my other inline comment below

[nemesifier]

you need to learn the concept of modules and how they interact otherwise you will never understand openwisp.

The PKI app of openwisp-controller (which handles certification authorities and certificates) is not aware of the internal logic of the Config app (which handles device configurations), so adding this test in the PKI app is a violation of this concept.

I think the best place to put this test is here: https://github.com/openwisp/openwisp-controller/blob/master/openwisp_controller/config/tests/test_template.py

(the Config app instead is aware of the PKI app because it needs it as a dependency so that's fine)

[atb00ker]

Is travis failing with "six>=1.11.0" ?

[nemesifier]

could be, these kind of builds are weird sometimes, I'll accept it

[nemesifier]

good job! 👍

[shashwat1002]

@nemesisdesign, @atb00ker thanks!