Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #62

Merged
merged 1 commit into from
Dec 2, 2018
Merged

Conversation

okraits
Copy link
Member

@okraits okraits commented Nov 15, 2018

Currently, the development version of openwisp-users is needed for HEAD of openwisp-controller.

Additionally, the package service-identity is required for the connections feature.

@coveralls
Copy link

coveralls commented Nov 15, 2018

Coverage Status

Coverage remained the same at 99.588% when pulling 7ff2796 on TDT-AG:tdt-fix-dependencies into 3f0d34a on openwisp:master.

setup.py Outdated
@@ -37,7 +37,8 @@
"django-netjsonconfig>=0.8.1,<0.10.0",
"openwisp-utils[users]<0.3",
"django-loci>=0.1.1,<0.3.0",
"djangorestframework-gis>=0.12.0,<0.14.0"
"djangorestframework-gis>=0.12.0,<0.14.0",
"service-identity"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a note in the connections branch PR, I'll need to do it there instead of here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it's my fault, I assumed that the connections branch is already merged, but it's not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the change in setup.py.

@nemesifier nemesifier merged commit 037a47d into openwisp:master Dec 2, 2018
@okraits okraits deleted the tdt-fix-dependencies branch December 2, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants