Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[travis] skip-lock during installation #64

Merged
merged 1 commit into from
Nov 20, 2018
Merged

[travis] skip-lock during installation #64

merged 1 commit into from
Nov 20, 2018

Conversation

atb00ker
Copy link
Member

Please correct me if i am wrong, but changing lock file during travis runs is not useful, right?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.588% when pulling 04d8c12cd6223f88c55a9cedb0e5878ddef4f346 on travis-qa into 75077b0 on master.

@openwisp openwisp deleted a comment from coveralls Nov 20, 2018
Copy link
Member

@okraits okraits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so, too. From my understanding, if we want to verify that our code works with the latest versions of the dependencies, then we should not use the lock file here but what is defined in the Pipfile. Thus your changes look correct to me.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks 👍

@nemesifier nemesifier merged commit ca5b39d into master Nov 20, 2018
@atb00ker atb00ker deleted the travis-qa branch November 28, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants